Re: API for setting colors of RGB backlit keyboard zones (was [PATCH V3] platform/x86: hp-wmi: Support omen backlight control wmi-acpi methods)

From: Pavel Machek
Date: Sat Feb 18 2023 - 06:48:32 EST


Hi!


> > I do agree with you that we need to avoid kbd_backlight in the name to avoid causing existing upower code to have weird interactions with this (it supports / assumes there is only 1 kbd_backlight LED class device).
> >
> > So lets go with just these 4:
> >
> > /sys/class/leds/hp_omen::kbd_zoned_backlight-1/
> > /sys/class/leds/hp_omen::kbd_zoned_backlight-2/
> > /sys/class/leds/hp_omen::kbd_zoned_backlight-3/
> > /sys/class/leds/hp_omen::kbd_zoned_backlight-4/
> >
> > Using the _zoned_ between kbd and baclight to avoid confusing the existing upower code. Then once this has landed we can look into extending upower support for this.
> >
> > Note the requested documentation patch should probably also explain that the _zoned_ was done deliberately to make current upower code ignore the devices.
> >

>
> This makes sense, I agree that the global LED file will cause more confusion
> and hacks in the code. I'll start working on the _zoned_ naming scheme with
> 4 files + documentation changes and make a patch for this soon!
>

/sys/class/leds/:rgb:kbd_zoned_backlight-4/ is better than what was
suggested above. But we already use _1 suffix to deduplicate the, so
I'm not sure this is best naming.

There are keyboards with per-key backlight. How do you suggest to
solve those?

Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.

Attachment: signature.asc
Description: PGP signature