RE: [PATCH v3] Drivers: vmbus: Check for channel allocation before looking up relids

From: Dexuan Cui
Date: Fri Feb 17 2023 - 18:17:45 EST


> From: Mohammed Gamal <mgamal@xxxxxxxxxx>
> Sent: Friday, February 17, 2023 12:44 PM
> ...
> --- a/drivers/hv/connection.c
> +++ b/drivers/hv/connection.c
> @@ -409,6 +409,10 @@ void vmbus_disconnect(void)
> */
> struct vmbus_channel *relid2channel(u32 relid)
> {
> + if (vmbus_connection.channels == NULL) {
> + pr_warn_once("relid2channel: relid=%d: No channels mapped!\n",
> relid);

Looks good to me except that the line exceeds 80 characters.
Please run "scripts/checkpatch.pl" to detect that.
For this patch, I guess Wei may be willing to help fix it.

> + return NULL;
> + }
> if (WARN_ON(relid >= MAX_CHANNEL_RELIDS))
> return NULL;
> return READ_ONCE(vmbus_connection.channels[relid]);
> --

Reviewed-by: Dexuan Cui <decui@xxxxxxxxxxxxx>