Re: [PATCH] padata: Make kobj_type structure constant

From: Daniel Jordan
Date: Fri Feb 17 2023 - 11:16:02 EST


On Fri, Feb 17, 2023 at 03:17:49AM +0000, Thomas Weißschuh wrote:
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
>
> Take advantage of this to constify the structure definition to prevent
> modification at runtime.
>
> Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>

I see the symbol in .rodata now. Thanks.

Acked-by: Daniel Jordan <daniel.m.jordan@xxxxxxxxxx>

> ---
> kernel/padata.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/padata.c b/kernel/padata.c
> index e007b8a4b738..106d08ee9ce2 100644
> --- a/kernel/padata.c
> +++ b/kernel/padata.c
> @@ -967,7 +967,7 @@ static const struct sysfs_ops padata_sysfs_ops = {
> .store = padata_sysfs_store,
> };
>
> -static struct kobj_type padata_attr_type = {
> +static const struct kobj_type padata_attr_type = {
> .sysfs_ops = &padata_sysfs_ops,
> .default_groups = padata_default_groups,
> .release = padata_sysfs_release,
>
> ---
> base-commit: 3ac88fa4605ec98e545fb3ad0154f575fda2de5f
> change-id: 20230217-kobj_type-padata-288edceca728
>
> Best regards,
> --
> Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
>