Re: [PATCH] dt-bindings: display: msm: sm6115-mdss: Fix DSI compatible

From: Krzysztof Kozlowski
Date: Fri Feb 17 2023 - 04:00:41 EST


On 16/02/2023 14:14, Konrad Dybcio wrote:
> Since the DSI autodetection is bound to work correctly on 6115 now,
> switch to using the correct per-SoC + generic fallback compatible
> combo.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> ---
> Depends on (and should have been a part of):
>
> https://lore.kernel.org/linux-arm-msm/20230213121012.1768296-1-konrad.dybcio@xxxxxxxxxx/
> .../devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml
> index 2491cb100b33..146d3e36d1c9 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml
> @@ -40,7 +40,9 @@ patternProperties:
> type: object
> properties:
> compatible:
> - const: qcom,dsi-ctrl-6g-qcm2290
> + items:
> + - const: qcom,sm6115-dsi-ctrl
> + - const: qcom,mdss-dsi-ctrl

You should rather keep old compatible as deprecated (so oneOf with two
options - items and const with deprecated).

Best regards,
Krzysztof