Re: [PATCH v5 4/5] LoongArch: Add support for kernel relocation

[Xi Ruoyao]

On Fri, 2023-02-17 at 15:26 +0800, Youling Tang wrote:

> This config allows to compile kernel as PIE and to relocate it at
> any virtual address at runtime: this paves the way to KASLR.
> Runtime relocation is possible since relocation metadata are embedded
> into the kernel.
> 
> Signed-off-by: Youling Tang <tangyouling@xxxxxxxxxxx>
> Signed-off-by: Xi Ruoyao <xry111@xxxxxxxxxxx> # Use arch_initcall
> Signed-off-by: Jinyang He <hejinyang@xxxxxxxxxxx> # Provide la_abs idea

Use Suggested-by if only "idea" is provided.

> +struct rela_la_abs {
> +               long offset;
> +               long symvalue;
> +};

Use one tab instead of two for the indent.

Otherwise LGTM.

-- 
Xi Ruoyao <xry111@xxxxxxxxxxx>
School of Aerospace Science and Technology, Xidian University