Re: [PATCH v9 1/8] x86/apic/x2apic: Allow CPU cluster_mask to be populated in parallel

[Kim Phillips]

On 2/15/23 8:54 AM, Usama Arif wrote:
> -
> -	cluster_hotplug_mask = kzalloc_node(sizeof(*cluster_hotplug_mask),
> -					    GFP_KERNEL, node);
> -	if (!cluster_hotplug_mask)
> -		return -ENOMEM;
> -	cluster_hotplug_mask->node = node;
> -	return 0;
> +	/*
> +	 * No CPU in the cluster has ever been initialized, so fall through to
> +	 * the boot time code which will also populate the cluster mask for any
> +	 * other CPU in the cluster which is (now) present.
> +	 */
> + alloc:
> +	cmsk = kzalloc_node(sizeof(*cmsk), GFP_KERNEL, node);
> +	if (!cmsk)
> + 		return -ENOMEM;

.git/rebase-apply/patch:167: space before tab in indent.
 		return -ENOMEM;

> +	per_cpu(cluster_masks, cpu) = cmsk;
> +	prefill_clustermask(cmsk, cpu, cluster);
> +
> + 	return 0;

.git/rebase-apply/patch:171: space before tab in indent.
 	return 0;
warning: 2 lines add whitespace errors.

Other than that:

Tested-by: Kim Phillips <kim.phillips@xxxxxxx>

Thanks,

Kim