Re: [PATCH 11/11] x86/sev: Change snp_guest_issue_request()'s fw_err argument

From: Borislav Petkov
Date: Thu Feb 16 2023 - 11:59:32 EST


On Thu, Feb 16, 2023 at 01:46:02PM +0100, Borislav Petkov wrote:
> @@ -390,18 +390,16 @@ static int __handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code,
> goto retry_request;
> }
>
> - if (fw_err)
> - *fw_err = override_err ?: err;
> -

As Tom pointed out offlist, we still need to do the error override.
Frankly, I'm not crazy about this request retrying as we do it but
I guess it is what it is and it is too late to change that now.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette