Re: [PATCH 2/2] leds: trigger: ledtrig-tty: add additional modes

From: Jiri Slaby
Date: Thu Feb 16 2023 - 01:45:46 EST


Hi,

On 14. 02. 23, 12:13, Florian Eckert wrote:
+static const char * const mode[] = {


This is not a wise name.

What do you suggest? For me, the 'mode' here was the most accurate.
It describes how the trigger should behave.

mode is fine but with a context. Like tty_led_mode.

thanks,
--
js