Re: [PATCH V2 1/2] dt-bindings: interrupt-controller: Add Loongson EIOINTC

From: Krzysztof Kozlowski
Date: Wed Feb 15 2023 - 15:12:26 EST


On 14/02/2023 13:43, Krzysztof Kozlowski wrote:
>>
>>>
>>>> +
>>>> + reg:
>>>> + minItems: 1
>>>> + maxItems: 3
>>>
>>> You need to describe the items.>>>
>>>> +
>>>> + interrupt-controller: true
>>>> +
>>>> + interrupts:
>>>> + description:
>>>> + Interrupt source of the CPU interrupts.
>>>
>>> You need to describe the items.
>>
>> Do you mean a more detailed description?
>
> I mean constraints on interrupts and/or description if they are not obvious.


Actually I noticed that for interrupts you provided the name, so it is
description and you just need maxItems:1.

The reg however need list of items which clearly documents what is there.

Best regards,
Krzysztof