Re: [PATCH v3 1/2] dt-bindings: arm: omap: add phytec pcm-049 som and pcm-959 dev board

[Colin Foster]

Hi Tony,

On Wed, Feb 15, 2023 at 09:14:43AM +0200, Tony Lindgren wrote:
> * Rob Herring <robh@xxxxxxxxxx> [230209 19:35]:
> > On Wed, Feb 08, 2023 at 06:55:24PM -0800, Colin Foster wrote:
> > > --- a/Documentation/devicetree/bindings/arm/omap/omap.txt
> > > +++ b/Documentation/devicetree/bindings/arm/omap/omap.txt
> > > @@ -131,6 +131,9 @@ Boards (incomplete list of examples):
> > >  - OMAP4 PandaBoard : Low cost community board
> > >    compatible = "ti,omap4-panda", "ti,omap4430", "ti,omap4"
> > >  
> > > +- OMAP4 PCM-959 : Commercial dev kit with PCM-049 SOM
> > > +  compatible = "phytec,pcm959", "phytec,pcm049", "ti,omap4460", "ti,omap4430", "ti,omap4";
> 
> Do you have both "ti,omap4460" and "ti,omap4430" SoCs variants for
> these boards? If not just drop the SoC variant not in use. If you do have,
> please mention it in the commit message.

I don't, no. It might not be an issue anymore, but I remember there was
some reason I thought it had to be there. That was back when I was
struggling to get anything booting, so it might have been a false
positive.

I'll remove it, or at the very least explain why it needs to be there in
the next version.

> 
> > OMAP maintainers, if no one is going to convert all of omap.txt over to 
> > schema, can we at least start an empty schema and add to it instead of 
> > here...
> 
> That sounds like a good plan to me as it allows moving one device at a
> time.
> 
> Colin, care to add the initial yaml binding file with your board?

I'll give it a go. To be clear, this would be
Documentation/devicetree/bindings/arm/omap.yaml and it would
include my device? I'm taking
Documentation/devicetree/bindings/arm/sunxi.yaml as inspiration (for no
reason other than it was the first one that I came across that seemed to
solve this same issue)

> 
> Regards,
> 
> Tony