Re: [Patch][next] dt-bindings: power: supply: Revise Richtek RT9467 compatible name

[Sebastian Reichel]

Hi,

On Wed, Feb 15, 2023 at 11:34:40AM +0800, ChiYuan Huang wrote:
> H, Krzysztof/Sebastian:
> On Tue, Feb 14, 2023 at 09:14:37AM +0100, Krzysztof Kozlowski wrote:
> > On 13/02/2023 21:53, Sebastian Reichel wrote:
> > > Hi,
> > > 
> > > On Wed, Feb 08, 2023 at 11:14:24AM +0800, ChiaEn Wu wrote:
> > >> Revise RT9467 compatible name from "richtek,rt9467-charger" to
> > >> "richtek,rt9467"
> > >>
> > >> Fixes: e1b4620fb503 ("dt-bindings: power: supply: Add Richtek RT9467 battery charger")
> > >> Signed-off-by: ChiaEn Wu <chiaen_wu@xxxxxxxxxxx>
> > >> ---
> > > 
> > > Is there a new version of this fixing the issues pointed out by Krzysztof?
> > > Also I think the filename and $id should be changed to richtek,rt9467.yaml
> > > in addition to the compatible change.
> > 
> > Yes, indeed.
> > 
> From the current discussion, there're things to be fixed.
> 1. In bindings, change compatible property from 'richtek,rt9467-charger' to 'richtek,rt9467'.
> 2. Rename 'richtek,rt9467-charger.yaml' to 'richtek,rt9467.yaml'
>
> Anything else? like as changing source code filename from from 'rt9467-charger.c' to 'rt9467.c"?

No, the source code can remain unchanged. But you also need to change
the $id line (line 4) in 'richtek,rt9467-charger.yaml' after renaming
file.

-- Sebastian

Attachment: signature.asc
Description: PGP signature