[PATCH v2 5/9] selftests/resctrl: Replace obsolete memalign() with posix_memalign()

From: Ilpo Järvinen
Date: Wed Feb 15 2023 - 08:06:58 EST


memalign() is obsolete according to its manpage.

Replace memalign() with posix_memalign() and remove malloc.h include
that was there for memalign().

As a pointer is passed into posix_memalign(), initialize *p to NULL
to silence a warning about the function's return value being used as
uninitialized (which is not valid anyway because the error is properly
checked before p is returned).

Suggested-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
---
tools/testing/selftests/resctrl/fill_buf.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/resctrl/fill_buf.c b/tools/testing/selftests/resctrl/fill_buf.c
index c20d0a7ecbe6..3cd0b337eae5 100644
--- a/tools/testing/selftests/resctrl/fill_buf.c
+++ b/tools/testing/selftests/resctrl/fill_buf.c
@@ -14,7 +14,6 @@
#include <sys/types.h>
#include <sys/wait.h>
#include <inttypes.h>
-#include <malloc.h>
#include <string.h>

#include "resctrl.h"
@@ -64,11 +63,13 @@ static void mem_flush(void *p, size_t s)

static void *malloc_and_init_memory(size_t s)
{
+ void *p = NULL;
uint64_t *p64;
size_t s64;
+ int ret;

- void *p = memalign(PAGE_SIZE, s);
- if (!p)
+ ret = posix_memalign(&p, PAGE_SIZE, s);
+ if (ret < 0)
return NULL;

p64 = (uint64_t *)p;
--
2.30.2