Re: [PATCH 1/2] dt-bindings: regulator: Add bindings for Richtek RT5739

From: Mark Brown
Date: Wed Feb 15 2023 - 08:03:40 EST


On Wed, Feb 15, 2023 at 10:00:56AM +0800, cy_huang@xxxxxxxxxxx wrote:

> + richtek,vsel-active-high:
> + description: |
> + If property is present, use the 'VSEL1' register group for buck control.
> + Else, use the 'VSEL0' register group. This depends on external hardware
> + 'VSEL' pin connecton.
> + type: boolean

I would expect this to be GPIO controlled rather than fixed in
the design, at least for some systems? The name suggests it's
supposed to control the polarity of a GPIO too. Sadly we don't
really have good infrastructure for fixed GPIOs AFAIK... ideally
this would be a GPIO and then if we need to hold it high then
there would be some binding we could connect to the GPIO that
says that. We don't have that though so for now a fixed property
might be OK.

Attachment: signature.asc
Description: PGP signature