Re: [PATCH 5.10 88/91] arm64/kexec: Test page size support with new TGRAN range values

From: heyuqiang
Date: Wed Feb 15 2023 - 05:58:21 EST


There is an error

tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git master
head: c911f03f8d444e623724fddd82b07a7e1af42338
commit: d5924531dd8ad012ad13eb4d6a5e120c3dadfc05 arm64/kexec: Test page size support with new TGRAN range values
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d5924531dd8ad012ad13eb4d6a5e120c3dadfc05

When I compile the ko file, I add [-Werror=type-limits] compilation options, an error is reported during compilation.

The log is as follows:

./arch/arm64/include/asm/cpufeature.h: In function ‘system_supports_4kb_granule’:
./arch/arm64/include/asm/cpufeature.h:653:14: error:
comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
return (val >= ID_AA64MMFR0_TGRAN4_SUPPORTED_MIN) &&
^~
./arch/arm64/include/asm/cpufeature.h: In function ‘system_supports_64kb_granule’:
./arch/arm64/include/asm/cpufeature.h:666:14: error:
comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
return (val >= ID_AA64MMFR0_TGRAN64_SUPPORTED_MIN) &&
^~

"val" variable type is "u32"
"#define ID_AA64MMFR0_TGRAN4_SUPPORTED_MIN 0x0"
"#define ID_AA64MMFR0_TGRAN64_SUPPORTED_MIN 0x0"
comparison of val >= 0 is always true.

If you fix the issue, kindly add following tag where applicable
Reported-by: heyuqiang <heyuqiang1@xxxxxxxxxx>

Thanks