Re: [PATCH v2 net-next] net: no longer support SOCK_REFCNT_DEBUG feature

From: Eric Dumazet
Date: Wed Feb 15 2023 - 03:34:33 EST


On Tue, Feb 14, 2023 at 5:15 AM Jason Xing <kerneljasonxing@xxxxxxxxx> wrote:
>
> From: Jason Xing <kernelxing@xxxxxxxxxxx>
>
> Commit e48c414ee61f ("[INET]: Generalise the TCP sock ID lookup routines")
> commented out the definition of SOCK_REFCNT_DEBUG in 2005 and later another
> commit 463c84b97f24 ("[NET]: Introduce inet_connection_sock") removed it.
> Since we could track all of them through bpf and kprobe related tools
> and the feature could print loads of information which might not be
> that helpful even under a little bit pressure, the whole feature which
> has been inactive for many years is no longer supported.
>
> Link: https://lore.kernel.org/lkml/20230211065153.54116-1-kerneljasonxing@xxxxxxxxx/
> Suggested-by: Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>
> Signed-off-by: Jason Xing <kernelxing@xxxxxxxxxxx>
>

Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>