RE: [PATCH v2 3/3] iommu: Remove ioasid infrastructure

From: Tian, Kevin
Date: Tue Feb 14 2023 - 22:27:24 EST


> From: Jacob Pan <jacob.jun.pan@xxxxxxxxxxxxxxx>
> Sent: Wednesday, February 15, 2023 1:05 AM
>
> Hi Jean-Philippe,
>
> On Tue, 14 Feb 2023 09:32:33 +0000, Jean-Philippe Brucker
> <jean-philippe@xxxxxxxxxx> wrote:
>
> > On Mon, Feb 13, 2023 at 10:44:14PM -0800, Jacob Pan wrote:
> > > +typedef unsigned int ioasid_t;
> > > +#ifdef CONFIG_IOMMU_SVA
> > > +static inline bool pasid_valid(ioasid_t ioasid)
> > > +{
> > > + return ioasid != IOMMU_PASID_INVALID;
> > > +}
> > > +#endif
> >
> > This isn't specific to SVA, doesn't need an ifdef
> >
> until DMA API PASID support is in, this is SVA only? at least on x86?
>

the name is pretty generic and it doesn't need SVA specific logic.