Re: [PATCH] PCI: Fix build error when CONFIG_PCI_MSI disabled

From: Reinette Chatre
Date: Tue Feb 14 2023 - 17:44:24 EST


Hi Bjorn,

On 2/14/2023 2:24 PM, Bjorn Helgaas wrote:

> I think this should have a "Fixes:" tag to connect it with the commit
> that added pci_msix_alloc_irq_at() and pci_msix_free_irq().
>

Thank you. I was not sure if a Fixes tag was needed since it does not
fix an existing issue but instead prevents a future issue.

> Looks like 34026364df8e ("PCI/MSI: Provide post-enable dynamic
> allocation interfaces for MSI-X").
>

Correct.

> Thomas merged 34026364df8e, so it would be best if he took the fixup
> as well.

Thomas did pick this up in tip's irq/urgent branch. While doing so he
added the Fixes tag that you proposed and also improved the subject.

Thank you very much

Reinette