Re: [PATCH 3/9] dt-bindings: soc: qcom: aoss: Document power-domain-cells for aoss

[Melody Olvera]

On 2/14/2023 9:52 AM, Bjorn Andersson wrote:
> On Mon, Feb 13, 2023 at 10:52:12AM -0800, Melody Olvera wrote:
>> Document "#-power-domain-cells" field for aoss devices as required
>> by power-controller bindings.
>>
> 99512191f4f1 ("soc: qcom: aoss: Drop power domain support") was merged
> in v5.16, so I don't think this is correct. Please let me know if I'm
> misunderstood your intent.

No, you're correct. Upon reviewing the that commit, this change is wrong and should
be dropped. I need to update the device tree accordingly. Thanks for catching that.

Thanks,
Melody
>
> Thanks,
> Bjorn
>
>> Signed-off-by: Melody Olvera <quic_molvera@xxxxxxxxxxx>
>> ---
>>  Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml
>> index ab607efbb64c..bcfa8e2e6a04 100644
>> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml
>> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml
>> @@ -60,6 +60,9 @@ properties:
>>      description:
>>        The single clock represents the QDSS clock.
>>  
>> +  "#power-domain-cells":
>> +    const: 1
>> +
>>  required:
>>    - compatible
>>    - reg
>> @@ -97,6 +100,7 @@ examples:
>>        mboxes = <&apss_shared 0>;
>>  
>>        #clock-cells = <0>;
>> +      #power-domain-cells = <1>;
>>  
>>        cx_cdev: cx {
>>          #cooling-cells = <2>;
>> -- 
>> 2.25.1
>>