Re: [PATCH v2 19/24] xtensa/cpu: Make sure cpu_die() doesn't return

[Steven Rostedt]

On Tue, 14 Feb 2023 10:23:22 -0800
Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:


> void __ref cpu_die(void)
> {
> 	idle_task_exit();
> 	local_irq_disable();
> 	__asm__ __volatile__(
> 			"	movi	a2, cpu_restart\n"
> 			"	jx	a2\n");
> 
> 	BUG();
> }
> 
> Hm, not only is the comment wrong, but it seems to be branching to
> cpu_restart?  That doesn't seem right at all.

Agreed, that does not look right at all.

-- Steve

> 
> Max/Chris?
>