Re: [PATCH v3] sched/psi: fix use-after-free in ep_remove_wait_queue()

From: Suren Baghdasaryan
Date: Tue Feb 14 2023 - 14:14:04 EST


On Tue, Feb 14, 2023 at 10:55 AM Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
>
> On Tue, Feb 14, 2023 at 10:13:35AM -0800, Munehisa Kamata wrote:
> > Using wake_up_pollfree() here might be less than ideal, but it also is not
> > fully contradicting the comment at commit 42288cb44c4b ("wait: add
> > wake_up_pollfree()") since the waitqueue's lifetime is not tied to file's
> > one and can be considered as another special case.
>
> If that comment is outdated now, then please update the comment too. We can do
> better than "not fully contradicting".

Agree. I don't see it contradicting that comment.

>
> - Eric