Re: [PATCH V2 net-next] net: fec: add CBS offload support

From: Andrew Lunn
Date: Tue Feb 14 2023 - 09:29:39 EST


> > > --- a/drivers/net/ethernet/freescale/fec_main.c
> > > +++ b/drivers/net/ethernet/freescale/fec_main.c
> > > @@ -66,6 +66,7 @@
> > > #include <linux/mfd/syscon.h>
> > > #include <linux/regmap.h>
> > > #include <soc/imx/cpuidle.h>
> > > +#include <net/pkt_sched.h>
> >
> > Some alphabetic order? At least for new files :D
> >
> I just want to keep the reverse Christmas tree style, although the whole #include
> order is already out of the style.

Reverse Christmass tree does not apply to includes, just local
variables. And the FEC driver has never been very good at it.

Andrew