Re: [PATCH] interconnect: qcom: qcm2290: Fix MASTER_SNOC_BIMC_NRT

From: Konrad Dybcio
Date: Tue Feb 14 2023 - 05:47:14 EST




On 3.01.2023 15:21, Konrad Dybcio wrote:
> Due to what seems to be a copy-paste error, the _NRT master was
> identical to the _RT master, which should not be the case.. Fix it
> using the values available from the downstream kernel [1].
>
> [1] https://android.googlesource.com/kernel/msm-extra/devicetree/+/refs/heads/android-msm-bramble-4.19-android11-qpr1/qcom/scuba-bus.dtsi#127
> Fixes: 1a14b1ac3935 ("interconnect: qcom: Add QCM2290 driver support")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> ---
Gentle bump

Konrad
> Not tested on real hw.
>
> drivers/interconnect/qcom/qcm2290.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/interconnect/qcom/qcm2290.c b/drivers/interconnect/qcom/qcm2290.c
> index 0da612d6398c..a29cdb4fac03 100644
> --- a/drivers/interconnect/qcom/qcm2290.c
> +++ b/drivers/interconnect/qcom/qcm2290.c
> @@ -147,9 +147,9 @@ static struct qcom_icc_node mas_snoc_bimc_nrt = {
> .name = "mas_snoc_bimc_nrt",
> .buswidth = 16,
> .qos.ap_owned = true,
> - .qos.qos_port = 2,
> + .qos.qos_port = 3,
> .qos.qos_mode = NOC_QOS_MODE_BYPASS,
> - .mas_rpm_id = 163,
> + .mas_rpm_id = 164,
> .slv_rpm_id = -1,
> .num_links = ARRAY_SIZE(mas_snoc_bimc_nrt_links),
> .links = mas_snoc_bimc_nrt_links,