Re: [PATCH] staging: pi433: change (struct pi433_tx_cfg)->bit_rate to be a u32

From: Dan Carpenter
Date: Tue Feb 14 2023 - 03:25:44 EST


On Tue, Feb 14, 2023 at 05:33:46PM +1100, Jacob Bai wrote:
> Based on the TODO file and datasheet of pi433, the maximum bit rate for
> transmitter is 300kbps when modulation been set to FSK. Hence, the size
> should be u32 rather than u16.
>
> Signed-off-by: Jacob Bai <jacob.bai.au@xxxxxxxxx>
> ---

This breaks the user space API.

The TODO was updated recently to explain how to do this properly.

regards,
dan carpenter