Re: [PATCH V4 4/5] arm64: dts: qcom: ipq9574: Add SMEM support

From: Krzysztof Kozlowski
Date: Tue Feb 14 2023 - 02:55:11 EST


On 14/02/2023 06:14, Poovendhan Selvaraj wrote:
> Add the required nodes to support SMEM
>
> Changes in V4:
> - Added required nodes for smem support
>
> Signed-off-by: Poovendhan Selvaraj <quic_poovendh@xxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/ipq9574.dtsi | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> index 898d7ce3f28d..2b41416d7f91 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> @@ -102,11 +102,17 @@
> #address-cells = <2>;
> #size-cells = <2>;
> ranges;
> -

No improvements here. For the third time.

This is a friendly reminder during the review process.

It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.

Thank you.

Best regards,
Krzysztof