Re: [PATCH 1/5] kernel: Move kernel_clone_args's fn to new struct

From: Linus Torvalds
Date: Mon Feb 13 2023 - 14:57:46 EST


On Sun, Feb 12, 2023 at 5:00 PM Mike Christie
<michael.christie@xxxxxxxxxx> wrote:
>
> The next patches will add callouts to set the task's comm, and create
> internal resources. This adds a new struct to for these callouts to
> organize them and reduce the args passed into kernel_thread and
> create_io_thread.

This patch too seems to just make things more complicated for no reason.

When the point was to make things simpler, adding a (pointless)
indirection through another structure seems to be against the whole
idea.

The code is neither simpler not more legible. Quite the reverse.

Linus