Re: [syzbot] WARNING: locking bug in umh_complete

[Peter Zijlstra]

On Mon, Feb 06, 2023 at 07:51:16AM -0800, Luis Chamberlain wrote:

> I think this seems to be the same issue that Schspa Shi reported / provided a
> fix sugggestion for [0]. This lead me to ask if:
> 
>   a) incorrect usage of completion on stack could be generic and;
>   b) if we should instead have an API helper for that?
> 
> Although he already implemented a suggestion for b) to answer a) we need
> some SmPL constructs yet to be written by Schspa. The reason I asked for
> b) is that if this is a regular pattern it begs for a) as this sort of
> issue could be prevalent in other places. So the status of Schspa's work
> was that he was going to work on the SmPL grammar to check how frequent
> this incorrect patern could be found.
> 
> Please let me know your thoughts as perhaps this issue / discussion
> didn't get on Peter's radar as it was rececently discussed with Schspa
> despite being on Cc.
> 
> [0] https://lore.kernel.org/all/m2pmcoag55.fsf@xxxxxxxxx/T/#u

-ETOODAMNMUCHEMAIL :-/

Urgh, esp. :

  https://lore.kernel.org/all/m2pmcoag55.fsf@xxxxxxxxx/T/#m9f0105d28fcfe4947a2583cd3d425169c4fe5dfa

is quite insane.