Re: [PATCH 3/4] media: dt-bindings: samsung,exynos4212-is: convert to dtschema

From: Rob Herring
Date: Mon Feb 13 2023 - 10:10:06 EST



On Sun, 12 Feb 2023 20:02:21 +0100, Krzysztof Kozlowski wrote:
> Convert the Samsung Exynos4212/4412 SoC Imaging Subsystem (FIMC-IS)
> bindings to DT schema. Changes during conversion - adjust to existing
> DTS and Linux driver: add iommus and power-domains.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
> .../bindings/media/exynos4-fimc-is.txt | 50 ----
> .../media/samsung,exynos4212-fimc-is.yaml | 221 ++++++++++++++++++
> MAINTAINERS | 1 +
> 3 files changed, 222 insertions(+), 50 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/exynos4-fimc-is.txt
> create mode 100644 Documentation/devicetree/bindings/media/samsung,exynos4212-fimc-is.yaml
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/media/samsung,exynos4212-fimc-is.example.dtb: /example-0/fimc-is@12000000/i2c-isp@12140000/image-sensor@10: failed to match any schema with compatible: ['samsung,s5k6a3']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230212190222.44977-3-krzysztof.kozlowski@xxxxxxxxxx

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.