Re: [PATCH 1/2] dt-bindings: display: panel: Add Novatek NT36523 bindings

[Jianhua Lu]

On Mon, Feb 13, 2023 at 12:08:27PM +0100, Krzysztof Kozlowski wrote:
> On 13/02/2023 12:04, Jianhua Lu wrote:
> > On Mon, Feb 13, 2023 at 11:45:23AM +0100, Krzysztof Kozlowski wrote:
> >> On 10/02/2023 17:19, Jianhua Lu wrote:
> >>> Novatek NT36523 is a display driver IC that can drive DSI panel. It
> >>> is also present in the csot and boe video mode panels. It is found
> >>> in Xiaomi Mi Pad 5 series.
> >>>
> >>> Signed-off-by: Jianhua Lu <lujianhua000@xxxxxxxxx>
> >>> ---
> >>>  .../display/panel/novatek,nt36523.yaml        | 101 ++++++++++++++++++
> >>>  1 file changed, 101 insertions(+)
> >>>  create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
> >>> new file mode 100644
> >>> index 000000000000..a7098d0ce7e1
> >>> --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
> >>> @@ -0,0 +1,101 @@
> >>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> >>> +%YAML 1.2
> >>> +---
> >>> +$id: http://devicetree.org/schemas/display/panel/novatek,nt36523.yaml#
> >>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >>> +
> >>> +title: Novatek NT36523 based DSI display Panels
> >>> +
> >>> +maintainers:
> >>> +  - Jianhua Lu <lujianhua000@xxxxxxxxx>
> >>> +
> >>> +description: |
> >>> +  The nt36523 IC from Novatek is a generic DSI Panel IC used to drive dsi
> >>> +  panels.
> >>> +  Right now, only support cost and boe LCD display panels with the
> >>
> >> boe? both?
> > Boe Technology Group Co., Ltd
> 
> Then what is "cost"? If both are names, then they start with capital
> letters or how the company officially spells itself.
both are company name, I will search offical name for it.
> 
> >>
> >>> +  resolution of 1600x2560. It is a video mode DSI panel.
> >>
> >> The binding or hardware supports only 1600x2560? The how it can be
> >> "right now"? It's defined, isn't it?
> > Yes
> 
> What yes? How it can be "right now"? It implies it will change, so how
> hardware can change?
sorry, my wrong. This binding only support 1600x2560.
> 
> 
> Best regards,
> Krzysztof
>