Re: [PATCH 6/6] dt-bindings: soc: amlogic: update sysctrl clock-controller subnode type

From: Neil Armstrong
Date: Mon Feb 13 2023 - 06:03:26 EST


Hi,

On 13/02/2023 12:00, Krzysztof Kozlowski wrote:
On 09/02/2023 14:41, Neil Armstrong wrote:
Since the clock controllers are now documented define the right ref
for the clock-controller subnodes and fill up the example node.

Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
---
.../soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml
index 672eabd90c09..57eae355f1b9 100644
--- a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml
+++ b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml
@@ -43,6 +43,10 @@ allOf:
- amlogic,meson-gx-hhi-sysctrl
- amlogic,meson-axg-hhi-sysctrl
then:
+ properties:
+ clock-controller:
+ $ref: /schemas/clock/amlogic,gxbb-clkc.yaml#

You just added this binding. I don't understand the split.

It's a chicken and egg problem, the clock controller bindings (patches 4 & 6)
I've added the system-controller top node in the DT example, but this
example won't be valid until I add the system-controller bindings.

To solve this, I add it in 2 steps, but if it's an *real* issue I can remove
the top system-controller nodes in the clock controller bindings and add them
later on and add the sysctrl bindings in one step.

Neil


+
required:
- power-controller
@@ -53,6 +57,10 @@ allOf:
- amlogic,meson-gx-ao-sysctrl
- amlogic,meson-axg-ao-sysctrl
then:
+ properties:
+ clock-controller:
+ $ref: /schemas/clock/amlogic,gxbb-aoclkc.yaml#
+
required:
- pinctrl
@@ -81,7 +89,12 @@ examples:
compatible = "amlogic,meson-gx-hhi-sysctrl", "simple-mfd", "syscon";
reg = <0 0x400>;
- clock-controller { };
+ clock-controller {
+ compatible = "amlogic,gxbb-clkc";
+ #clock-cells = <1>;
+ clocks = <&xtal>;
+ clock-names = "xtal";


Best regards,
Krzysztof