Re: [PATCH V5 1/1] clk: imx8mp: Alias M7 SRC/DIV to M7 CORE

From: Abel Vesa
Date: Mon Feb 13 2023 - 02:42:09 EST


On 23-01-30 14:34:30, Stephen Boyd wrote:
> Quoting LI Qingwu (2023-01-29 23:44:22)
> >
> > > > Is it needed for clk-fixes? When did the system start hanging?
> > >
> > > Li, Peng, can you provide some details here?
> >
> > Since IMX8MP_CLK_M7_SRC and IMX8MP_CLK_M7_DIV were not assigned,
> > if using any one of them in device tree, Linux system hanging after start M7 core.
>
> $ git grep -e IMX8MP_CLK_M7_SRC -o -e IMX8MP_CLK_M7_DIV
> include/dt-bindings/clock/imx8mp-clock.h:IMX8MP_CLK_M7_SRC
> include/dt-bindings/clock/imx8mp-clock.h:IMX8MP_CLK_M7_DIV
>
> so we're OK to let Abel apply this?

Replying here as the CC emails in Li's next-in-thread email are all messed up and
the reply I sent there bounced back.

As Stephen pointed out, in upstream, there is no current user for those
two clock IDs. So I suppose we can keep the Fixes tag, but currently,
on upstream, there is no chance a consumer could hang as there is no
consumer yet for these clocks.

Stephen, I'll add this to my 6.4 material, again, since there is no
actual comsumer yet, if that's OK with you.