Re: [PATCH] get_maintainer: add email addresses from dts files

From: Joe Perches
Date: Sun Feb 12 2023 - 16:13:31 EST


On Sun, 2023-02-12 at 16:51 +0100, Krzysztof Kozlowski wrote:
> On 11/02/2023 17:27, Joe Perches wrote:
> > On Sat, 2023-02-11 at 13:14 +0100, Krzysztof Kozlowski wrote:
> > > The DTS/DTSI files represent hardware description for Linux kernel,
> > > which is necessary to properly recognize and configure hardware by
> > > Linux. DTS is usually created by people having the actual hardware and
> > > having interest in keeping it in good shape. Such people can provide
> > > review (they might have board schematics) and testing. Unfortunately
> > > they mostly do not appear in MAINTAINERS file. Adding per-DTS entries
> > > to MAINTAINERS would quickly make it bloated (hundreds of new per-DTS
> > > entries).
> > >
> > > On the other hand there is no point in CC-ing every Copyright email
> > > appearing in files, because it might be outdated.

That's what .mailmap is for.

> > > Add new in-file
> > > pattern for storing maintainers dedicated to specific boards:

I think adding Maintainer: who <who@xxxxxxx>

to each dts and dtsi file would be a lot of unnecessary changes
$ git ls-files | grep -P '\.dtsi?$' | wc -l
4673

> > > This is rework of earlier approach:
> > > Link: https://lore.kernel.org/r/20210809080204.8381-1-shawnguo@xxxxxxxxxx
> >
> > Why the rework? I think the older one is much simpler.
> >
> > I believe I forwarded the older one to Andrew Morton awhile back.
> > I'll check to see what happened to it.
>
> It was never merged, thus I assumed some changes are needed, e.g. to
> ignore emails in copyrights.

I think the old one is fine.