Re: [PATCH 02/12] pata_parport: Introduce module_pata_parport_driver macro

[Ondrej Zary]

On Sunday 12 February 2023 13:19:28 Sergey Shtylyov wrote:
> On 2/11/23 5:42 PM, Ondrej Zary wrote:
> 
> > Introduce module_pata_parport_driver macro and use it in protocol
> > drivers to reduce boilerplate code. Remove paride_(un)register
> > compatibility defines.
> > 
> > Signed-off-by: Ondrej Zary <linux@xxxxxxx>
> [...]
> 
> > diff --git a/drivers/ata/pata_parport/bpck6.c b/drivers/ata/pata_parport/bpck6.c
> > index d897e2a28efe..3c358e66db25 100644
> > --- a/drivers/ata/pata_parport/bpck6.c
> > +++ b/drivers/ata/pata_parport/bpck6.c
> > @@ -245,23 +245,8 @@ static struct pi_protocol bpck6 = {
> >  	.release_proto	= bpck6_release_proto,
> >  };
> >  
> > -static int __init bpck6_init(void)
> > -{
> > -	printk(KERN_INFO "bpck6: BACKPACK Protocol Driver V"BACKPACK_VERSION"\n");
> > -	printk(KERN_INFO "bpck6: Copyright 2001 by Micro Solutions, Inc., DeKalb IL. USA\n");
> > -	if(verbose)
> > -		printk(KERN_DEBUG "bpck6: verbose debug enabled.\n");
> 
>    Hm, perhaps should've been removed in a separate patch?
> 
> [...]
> > diff --git a/drivers/ata/pata_parport/epat.c b/drivers/ata/pata_parport/epat.c
> > index 6ce2dee7657f..eb72bcd0c8da 100644
> > --- a/drivers/ata/pata_parport/epat.c
> > +++ b/drivers/ata/pata_parport/epat.c
> > @@ -327,12 +327,12 @@ static int __init epat_init(void)
> >  #ifdef CONFIG_PARIDE_EPATC8
> 
>    Hm, this is now called PATA_PARPORT_EPATC8, no?

Yes, it's a bug. This compile-time option should go away completely.

> >  	epatc8 = 1;
> 
>    Seems like a dead code?
> 
> >  #endif
> [...]
> 
> MBR, Sergey
> 


-- 
Ondrej Zary