RE: [PATCH] interconnect: Skip call into provider if initial bw is zero

From: Peng Fan
Date: Sun Feb 12 2023 - 05:58:19 EST



> Subject: Re: [PATCH] interconnect: Skip call into provider if initial bw is zero
>
> On 23-01-23 22:58:49, Bryan O'Donoghue wrote:
> > On 23/01/2023 20:37, Mike Tipton wrote:
> > >
> > > This isn't actually changing it for all providers. Only for those
> > > that define the get_bw() callback. Right now that's only
> > > qcom/msm8974 and imx/imx. If get_bw() isn't defined, then
> > > icc_node_add() defaults to INT_MAX. So, the logical behavior in that
> > > case is unchanged. Which means this isn't even changing the behavior
> for rpmh yet, either.
> >
> > Yes that adds up.
> >
> > Looking at the commit for get_bw() for the 8974, I think this change
> > would be OK with the intent of this commit
> >
> > commit 9caf2d956cfa254c6d89c5f4d7b3f8235d75b28f
> > Author: Georgi Djakov <georgi.djakov@xxxxxxxxxx>
> > Date: Mon Nov 9 14:45:12 2020 +0200
> >
> > @Abel what effect will skipping pre->aggregation() have on i.MX ?
>
> I don't think there is any impact on i.MX platforms.
>
> Peng, any input?

Thanks for CC me.

No impact on i.MX.

Thanks,
Peng.
>
> >
> > ---
> > bod