Re: [PATCH 3/3] HID: apple-magic-backlight: Add driver for keyboard backlight on internal Magic Keyboards

From: Aditya Garg
Date: Sun Feb 12 2023 - 00:16:38 EST




> On 11-Feb-2023, at 10:26 PM, Pavel Machek <pavel@xxxxxx> wrote:
>
> Hi!
>
>> From: Orlando Chamberlain <orlandoch.dev@xxxxxxxxx>
>>
>> This driver adds support for the keyboard backlight on Intel T2 Macs
>> with internal Magic Keyboards (MacBookPro16,x and MacBookAir9,1)
>
>> + backlight->hdev = hdev;
>> + backlight->cdev.name = "apple::kbd_backlight";
>
> ":white:kbd_backlight", plus document this in
> Documentation/leds/well-known-leds.txt so that we keep it consistent
> accross machines?

We had used the same name for butterfly keyboards, the code being in hid-apple

Will that also be needed to be changed?

>
> Thanks,
> Pavel
> --
> People of Russia, stop Putin before his war on Ukraine escalates.