Re: [PATCH v6] soc: nuvoton: Add SoC info driver for WPCM450

From: Jonathan Neuschäfer
Date: Sat Feb 11 2023 - 15:13:59 EST


On Sat, Feb 11, 2023 at 10:33:05AM +0100, Geert Uytterhoeven wrote:
> Hi Jonathan,
>
> On Sat, Feb 11, 2023 at 2:03 AM Jonathan Neuschäfer
> <j.neuschaefer@xxxxxxx> wrote:
> > On Fri, Feb 10, 2023 at 11:26:28AM +0100, Geert Uytterhoeven wrote:
> > > On Thu, Nov 3, 2022 at 10:37 PM Jonathan Neuschäfer
> > > <j.neuschaefer@xxxxxxx> wrote:
> > > > Add a SoC information driver for Nuvoton WPCM450 SoCs. It provides
> > > > information such as the SoC revision.
[...]
> > > > +config WPCM450_SOC
> > > > + tristate "Nuvoton WPCM450 SoC driver"
> > > > + default y if ARCH_WPCM450
> > > > + select SOC_BUS
> > > > + select REGMAP
> > > > + help
> > > > + Say Y here to compile the SoC information driver for Nuvoton
> > > > + WPCM450 SoCs.
> > > > +
> > > > + This driver provides information such as the SoC model and
> > > > + revision.
> > > > +
> > > > +endmenu
> > >
> > > Do you plan to send a follow-up patch?
> >
> > Yes, hopefully I'll get around to it a few days after rc1, when the dust
> > of the (upcoming) merge window has settled a bit.
> >
> > Or should I rather send it earlier?
>
> I'd say sooner rather than later.
> If I hadn't found your v6, I would have sent a patch myself to add the
> dependency.

Ok, I'll send it today.

>
> Does the "select REGMAP" fix a build issue? If yes, that's a very good
> reason to send it now...

Unfortunately I wasn't able to find the build issue report.


Jonathan

Attachment: signature.asc
Description: PGP signature