Re: [PATCH] regulator: dt-bindings: qcom,rpmh: Correct PM8550 family supplies

[Abel Vesa]

On 23-02-10 16:59:30, Krzysztof Kozlowski wrote:
> PM8550 is different than PM8550VE/VS, because the latter has much
> smaller amount of supplies (l1-3 and s1-6) and regulators.  The PM8550
> has on theh other hand one pin for vdd-l1-l4-l10 supplies.  Correct the

Nit: ... on the other ...

> if:then: clause with their supplies.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Otherwise, LGTM:

Reviewed-by: Abel Vesa <abel.vesa@xxxxxxxxxx>

> ---
>  .../bindings/regulator/qcom,rpmh-regulator.yaml  | 16 +++++++++++++---
>  1 file changed, 13 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
> index 297a75069f60..fb9621b4b4cd 100644
> --- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
> @@ -308,19 +308,29 @@ allOf:
>          compatible:
>            enum:
>              - qcom,pm8550-rpmh-regulators
> -            - qcom,pm8550ve-rpmh-regulators
> -            - qcom,pm8550vs-rpmh-regulators
>      then:
>        properties:
> +        vdd-l1-l4-l10-supply: true
>          vdd-l2-l13-l14-supply: true
>          vdd-l5-l16-supply: true
>          vdd-l6-l7-supply: true
>          vdd-l8-l9-supply: true
>        patternProperties:
> -        "^vdd-l([1-4]|1[0-7])-supply$": true
> +        "^vdd-l(3|1[1-7])-supply$": true
>          "^vdd-s[1-6]-supply$": true
>          "^vdd-bob[1-2]-supply$": true
>  
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - qcom,pm8550ve-rpmh-regulators
> +            - qcom,pm8550vs-rpmh-regulators
> +    then:
> +      patternProperties:
> +        "^vdd-l[1-3]-supply$": true
> +        "^vdd-s[1-6]-supply$": true
> +
>    - if:
>        properties:
>          compatible:
> -- 
> 2.34.1
>