Re: [PATCH] soc: dove: release node before breaking child_of_node loop

From: Andrew Lunn
Date: Sat Feb 11 2023 - 12:51:30 EST


On Sat, Feb 11, 2023 at 09:44:47PM +0530, Deepak R Varma wrote:
> The iterator for_each_available_child_of_node() increments the refcount
> of the child node it is processing. Release such a reference when the
> loop needs to break due to an error during its execution.
> Issue identified using for_each_child.cocci Coccinelle semantic patch.
>
> Signed-off-by: Deepak R Varma <drv@xxxxxxxxx>

Looks reasonable.

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew