Re: [PATCH v4 12/12] net: dsa: mt7530: use external PCS driver

From: Russell King (Oracle)
Date: Sat Feb 11 2023 - 08:00:34 EST


Hi Daniel,

On Fri, Feb 10, 2023 at 11:40:40PM +0000, Daniel Golle wrote:
> Implement regmap access wrappers, for now only to be used by the
> pcs-mtk driver.
> Make use of external PCS driver and drop the reduntant implementation
> in mt7530.c.
> As a nice side effect the SGMII registers can now also more easily be
> inspected for debugging via /sys/kernel/debug/regmap.
>
> Tested-by: Bjørn Mork <bjorn@xxxxxxx>
> Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx>

Nothing obviously wrong.

Reviewed-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>

Thanks!

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!