Re: [PATCH v6] soc: nuvoton: Add SoC info driver for WPCM450

From: Jonathan Neuschäfer
Date: Fri Feb 10 2023 - 20:03:24 EST


On Fri, Feb 10, 2023 at 11:26:28AM +0100, Geert Uytterhoeven wrote:
> Hi Jonathan,
>
> On Thu, Nov 3, 2022 at 10:37 PM Jonathan Neuschäfer
> <j.neuschaefer@xxxxxxx> wrote:
> > Add a SoC information driver for Nuvoton WPCM450 SoCs. It provides
> > information such as the SoC revision.
> >
> > Usage example:
> >
> > # grep . /sys/devices/soc0/*
> > /sys/devices/soc0/family:Nuvoton NPCM
> > /sys/devices/soc0/revision:A3
> > /sys/devices/soc0/soc_id:WPCM450
> >
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@xxxxxxx>
> > Reviewed-by: Joel Stanley <joel@xxxxxxxxx>
> > Reviewed-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx>
> > ---
> > v6:
> > - Select REGMAP
> > - Rearrange Kconfig structure a bit
>
> Thanks for your patch!
>
> Unfortunately Joel seems to have sent v5 to Arnd instead of v6?
> https://lore.kernel.org/all/20230201051717.1005938-1-joel@xxxxxxxxx
>
> Which is now commit 7dbb4a38bff34493 ("soc:
> nuvoton: Add SoC info driver for WPCM450") in soc/for-next...
>
> > --- /dev/null
> > +++ b/drivers/soc/nuvoton/Kconfig
> > @@ -0,0 +1,17 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +menu "Nuvoton SoC drivers"
> > + depends on ARCH_NPCM || COMPILE_TEST
>
> ... and lacks the above dependency, hence appearing on my radar.
>
> > +
> > +config WPCM450_SOC
> > + tristate "Nuvoton WPCM450 SoC driver"
> > + default y if ARCH_WPCM450
> > + select SOC_BUS
> > + select REGMAP
> > + help
> > + Say Y here to compile the SoC information driver for Nuvoton
> > + WPCM450 SoCs.
> > +
> > + This driver provides information such as the SoC model and
> > + revision.
> > +
> > +endmenu
>
> Do you plan to send a follow-up patch?

Yes, hopefully I'll get around to it a few days after rc1, when the dust
of the (upcoming) merge window has settled a bit.

Or should I rather send it earlier?

Jonathan

> Thanks!
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds

Attachment: signature.asc
Description: PGP signature