Re: [PATCH v3 10/12] net: pcs: add driver for MediaTek SGMII PCS

From: Russell King (Oracle)
Date: Fri Feb 10 2023 - 16:46:03 EST


On Thu, Feb 09, 2023 at 11:34:47PM +0000, Daniel Golle wrote:
> The SGMII core found in several MediaTek SoCs is identical to what can
> also be found in MediaTek's MT7531 Ethernet switch IC.
> As this has not always been clear, both drivers developed different
> implementations to deal with the PCS.
>
> Add a dedicated driver, mostly by copying the code now found in the
> Ethernet driver. The now redundant code will be removed by a follow-up
> commit.
>
> Tested-by: Bjørn Mork <bjorn@xxxxxxx>
> Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx>

Comments on v2 also apply to this version.

(this is mainly for net-next tracking review purposes.)
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!