Re: [PATCH V5 1/3] dt-bindings: i2c: xiic: Add 'xlnx,axi-iic-2.1' to compatible

From: Krzysztof Kozlowski
Date: Fri Feb 10 2023 - 06:40:41 EST


On 09/02/2023 12:37, Manikanta Guntupalli wrote:
> From: Raviteja Narayanam <raviteja.narayanam@xxxxxxxxxx>
>
> Add xilinx I2C new version 'xlnx,axi-iic-2.1' string to compatible

A nit: Missing full stop in this sentence.

> Add clock-frequency as optional property.
>
> Signed-off-by: Raviteja Narayanam <raviteja.narayanam@xxxxxxxxxx>
> Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@xxxxxxx>
> Acked-by: Michal Simek <michal.simek@xxxxxxx>
> ---


>
> + clock-frequency:
> + description:
> + Optional I2C SCL clock frequency. If not specified, do not configure
> + in software, rely only on hardware design value. Supported frequencies
> + are 100KHz, 400KHz and 1MHz.
> + default: 100000

Then also:
enum: [ 100000, 400000, 1000000 ]

and drop the freeform text (last sentence from description).

Best regards,
Krzysztof