Re: [PATCH 2/3] mips: dts: ralink: mt7621: add phandle to system controller node for watchdog

From: Sergio Paracuellos
Date: Fri Feb 10 2023 - 06:29:22 EST


Hi Krzysztof,

On Fri, Feb 10, 2023 at 12:00 PM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> On 10/02/2023 07:56, Sergio Paracuellos wrote:
> > To allow to access system controller registers from watchdog driver code
> > add a phandle in the watchdog 'wdt' node. This avoid using arch dependent
>
> ??? This does not make sense.

What do you mean? The commit message itself? I need the phandle to
'sysc' system controller node for accessing reset status registers
inside the watchdog driver code.

>
> > operations in driver code.
> >
> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>
> > ---
> > arch/mips/boot/dts/ralink/mt7621.dtsi | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi
> > index 5ca40fd21..ebee23a2b 100644
> > --- a/arch/mips/boot/dts/ralink/mt7621.dtsi
> > +++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
> > @@ -71,8 +71,9 @@ sysc: syscon@0 {
> > };
> >
> > wdt: wdt@100 {
> > - compatible = "mediatek,mt7621-wdt";
> > + compatible = "mediatek,mt7621-wdt", "syscon";
>
> Why do you need syscon?

True, will drop, thanks!

>
> Best regards,
> Krzysztof
>

Best regards,
Sergio Paracuellos