Re: [PATCH v1 1/3] ALSA: hda/cs35l41: Fix error condition check

From: Takashi Iwai
Date: Fri Feb 10 2023 - 04:11:15 EST


On Thu, 09 Feb 2023 17:04:01 +0100,
Stefan Binding wrote:
>
> From: Vitaly Rodionov <vitalyr@xxxxxxxxxxxxxxxxxxxxx>
>
> Function hda_cs_dsp_write_ctl() returns 3 possible values:
> 0 - no change, 1 - value has changed and -1 - error, so value 1
> is not an error.
>
> Signed-off-by: Vitaly Rodionov <vitalyr@xxxxxxxxxxxxxxxxxxxxx>

When you submit a patch, you must add your Signed-off-by line.

Also, this looks like no new bug, so it's worth to add Fixes tag, if
any? (Not only about this patch but others, too.)

Last but not least, please make the subject prefix consistent over the
patch series.


thanks,

Takashi