Re: [PATCH 1/2] ASoC: rt5640: Update MCLK rate in set_sysclk()

From: Kuninori Morimoto
Date: Thu Feb 09 2023 - 18:43:59 EST



Hi Sameer

> Simple-card/audio-graph-card drivers do not handle MCLK clock when it
> is specified in the codec device node. The expectation here is that,
> the codec should actually own up the MCLK clock and do necessary setup
> in the driver.

I have no objection about this patch, but have interesting about this comment.

Simple-card/audio-graph-card both are using asoc_simple_hw_params,
and it calls clk_set_rate() for Codec/CPU if it has mclk.
But am I misunderstanding ?
If it was simple-card-utils side miss, I'm happy to fix it.

Thank you for your help !!

Best regards
---
Kuninori Morimoto