[tip: timers/core] time/debug: Fix memory leak with using debugfs_lookup()

From: tip-bot2 for Greg Kroah-Hartman
Date: Thu Feb 09 2023 - 14:16:52 EST


The following commit has been merged into the timers/core branch of tip:

Commit-ID: 5b268d8abaec6cbd4bd70d062e769098d96670aa
Gitweb: https://git.kernel.org/tip/5b268d8abaec6cbd4bd70d062e769098d96670aa
Author: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
AuthorDate: Thu, 02 Feb 2023 16:12:14 +01:00
Committer: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
CommitterDate: Thu, 09 Feb 2023 20:12:27 +01:00

time/debug: Fix memory leak with using debugfs_lookup()

When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time. To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic at
once.

Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Link: https://lore.kernel.org/r/20230202151214.2306822-1-gregkh@xxxxxxxxxxxxxxxxxxx

---
kernel/time/test_udelay.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/time/test_udelay.c b/kernel/time/test_udelay.c
index 13b11eb..20d5df6 100644
--- a/kernel/time/test_udelay.c
+++ b/kernel/time/test_udelay.c
@@ -149,7 +149,7 @@ module_init(udelay_test_init);
static void __exit udelay_test_exit(void)
{
mutex_lock(&udelay_test_lock);
- debugfs_remove(debugfs_lookup(DEBUGFS_FILENAME, NULL));
+ debugfs_lookup_and_remove(DEBUGFS_FILENAME, NULL);
mutex_unlock(&udelay_test_lock);
}