Re: [PATCH v2 01/10] dt-bindings: media: mediatek,vcodec: Remove dma-ranges property

From: Rob Herring
Date: Thu Feb 09 2023 - 12:43:15 EST



On Wed, 08 Feb 2023 13:36:34 +0800, Yong Wu wrote:
> After commit f1ad5338a4d5 ("of: Fix "dma-ranges" handling for bus
> controllers"), the dma-ranges of the leaf node doesn't work. Remove
> it for vcodec here.
>
> 1) For mediatek,vcodec-decoder.yaml and mediatek,vcodec-encoder.yaml,
> this property is in the leaf node, it is invalid as the above comment.
>
> Currently there is only mt8195 VENC node has this property in upstream.
> Indeed, VENC is affected, but it is not a fatal issue. Originally it
> expects its iova range locate at 4GB-8GB. However after that commit, its
> expectation doesn't come true, it will fall back to 0-4GB iova and also
> could work well.
>
> 2) For mediatek,vcodec-subdev-decoder.yaml, It already uses parent-child
> node, this property works. Instead, MediaTek iommu will control the
> masters' iova ranges by the master's larb/port id internally, then the
> dma-ranges property is unnecessary for the master's node.
>
> Cc: Tiffany Lin <tiffany.lin@xxxxxxxxxxxx>
> Cc: Andrew-CT Chen <andrew-ct.chen@xxxxxxxxxxxx>
> Cc: Yunfei Dong <yunfei.dong@xxxxxxxxxxxx>
> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> Cc: Matthias Brugger <matthias.bgg@xxxxxxxxx>
> Signed-off-by: Yong Wu <yong.wu@xxxxxxxxxxxx>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/media/mediatek,vcodec-decoder.yaml | 5 -----
> .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml | 5 -----
> .../bindings/media/mediatek,vcodec-subdev-decoder.yaml | 7 -------
> 3 files changed, 17 deletions(-)
>

Acked-by: Rob Herring <robh@xxxxxxxxxx>