Re: [PATCH v3] iommu/vt-d: Fix PASID directory pointer coherency

From: Jacob Pan
Date: Thu Feb 09 2023 - 12:03:54 EST


Hi Kevin,

On Thu, 9 Feb 2023 02:08:23 +0000, "Tian, Kevin" <kevin.tian@xxxxxxxxx>
wrote:

> > @@ -1976,6 +1976,8 @@ static int domain_context_mapping_one(struct
> > dmar_domain *domain,
> > pds = context_get_sm_pds(table);
> > context->lo = (u64)virt_to_phys(table->table) |
> > context_pdts(pds);
> > + if (!ecap_coherent(iommu->ecap))
> > + clflush_cache_range(table->table,
> > sizeof(u64));
>
> this is not required if cache is already flushed when the table is
> allocated.
yes you're right.

Thanks,

Jacob