Re: [PATCH v3 04/10] sched/fair: Let low-priority cores help high-priority busy SMT cores

From: Peter Zijlstra
Date: Thu Feb 09 2023 - 07:04:33 EST


On Wed, Feb 08, 2023 at 08:56:32AM +0100, Vincent Guittot wrote:

> > + if (env->sd->flags & SD_SHARE_CPUCAPACITY ||
> > + (!(env->sd->flags & SD_SHARE_CPUCAPACITY) && is_core_idle(i)))
>
> This 2nd if could be merged with the upper one

Wasn't this exact same condition used in the previous patch as well?
Does it wants to be a helper perhaps?