Re: [PATCH RFC] linux: net: phy: realtek: changing LED behaviour for RTL8211F

[Simon Horman]

On Thu, Feb 09, 2023 at 10:44:05AM +0100, Oliver Graute wrote:
> This enable the LEDs for network activity and 100/1000Link for the RTL8211F
> 
> Signed-off-by: Oliver Graute <oliver.graute@xxxxxxxxxxxxxxxxx>
> ---
>  drivers/net/phy/realtek.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
> index 3d99fd6664d7..5c796883cad3 100644
> --- a/drivers/net/phy/realtek.c
> +++ b/drivers/net/phy/realtek.c
> @@ -416,6 +416,11 @@ static int rtl8211f_config_init(struct phy_device *phydev)
>  		}
>  	}
>  
> +        phy_write(phydev, RTL821x_PAGE_SELECT, 0xd04);
> +        phy_write(phydev, 0x10, 0x15B);
> +
> +        phy_write(phydev, RTL821x_PAGE_SELECT, 0x0);
> +

nit: it looks like the indentation in the new lines above should
     be using a single tab rather than 8 spaces.

>  	return genphy_soft_reset(phydev);
>  }
>  
> -- 
> 2.17.1
>