Re: [PATCH] net: fec: Defer probe if other FEC has deferred MDIO

[Sverdlin, Alexander]

Hello Andrew,

On Thu, 2023-02-09 at 01:55 +0100, Andrew Lunn wrote:
> > -       if ((fep->quirks & FEC_QUIRK_SINGLE_MDIO) && fep->dev_id >
> > 0) {
> > +       if (fep->quirks & FEC_QUIRK_SINGLE_MDIO) {
> >                 /* fec1 uses fec0 mii_bus */
> >                 if (mii_cnt && fec0_mii_bus) {
> >                         fep->mii_bus = fec0_mii_bus;
> >                         mii_cnt++;
> >                         return 0;
> >                 }
> > -               return -ENOENT;
> 
> Could you not add an else clause here? return -EPROBE_DEFFER?
> 
> Basically, if fec0 has not probed, deffer the probing of fec1?

we do have a configuration with i.MX8 where we have only fec2 enabled
(and has mdio node).
I'm not sure if it was thought of by fec driver developers (it makes
a lot of non-obvious assumtions), but that's how it works now. 

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com